From: Jasper St. Pierre Date: Wed, 11 Sep 2013 01:53:19 +0000 (-0400) Subject: Bind "this" for various methods X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~3455 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=2d8ed4c77ff54cece41edbfd66239c5514857ec4;p=gnome-shell.git Bind "this" for various methods For extremely silly reasons with how the class framework works, the wrapper method requires "this" to be bound in order for it to work, or else we'll emit errors in strict mode. https://bugzilla.gnome.org/show_bug.cgi?id=707892 --- diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js index e0a4182a1..6d4586e08 100644 --- a/js/ui/appDisplay.js +++ b/js/ui/appDisplay.js @@ -125,7 +125,7 @@ const BaseAppView = new Lang.Class({ }, loadGrid: function() { - this._allItems.sort(this._compareItems); + this._allItems.sort(Lang.bind(this, this._compareItems)); for (let i = 0; i < this._allItems.length; i++) { let id = this._getItemId(this._allItems[i]); diff --git a/js/ui/status/network.js b/js/ui/status/network.js index 879d7bfa1..029c4ca90 100644 --- a/js/ui/status/network.js +++ b/js/ui/status/network.js @@ -244,7 +244,7 @@ const NMConnectionSection = new Lang.Class({ this.emit('activation-failed', reason); })); - let pos = Util.insertSorted(this._connections, connection, this._connectionSortFunction); + let pos = Util.insertSorted(this._connections, connection, Lang.bind(this, this._connectionSortFunction)); this._labelSection.addMenuItem(item.labelItem, pos); this._switchSection.addMenuItem(item.switchItem, pos); this._connectionItems.set(connection.get_uuid(), item);